git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git log -z doesn't separate commits with NULs

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 24, 2012, 22:27 UTC
Message-ID
<7v7gzbhnoh.fsf@alter.siamese.dyndns.org>
In-Reply-To
<201202242311.04787.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
> Perhaps git-format-patch should mention that it was created with
> path-limited patch in some email pseudo-header like X-Pathspec:
> or something, don't you think?

What kind of workflow are you assuming, and who would benefit from such a header under that assumption?

It obviously would not help the person who is running format-patch, as he is very well aware that he is giving a pathspec when he runs the command. If the result is used privately to prepare a starting point of possibly unrelated work, it does not matter.

If you are assuming a workflow that involves a public review of mailed patches, it is very likely that such a header will be lost unless you are using git-send-email, as we strongly discourage copying and pasting the entire thing in the message body. Anybody sitting on the receiving end worth her salt would judge the submission by looking at the log message, diffstat and the patch, and the sender having used pathspec to format the patch would not be a reason for rejection at all---the quality of the submission is.

So offhand, I do not know under what workflow such an extra header would benefit people in what position in the workflow.

Previous: Jakub NarebskiNext: Andreas Schwab
Message 20 of 22 in “git log -z doesn't separate commits with NULs”
  1. Nikolaj ShurkaevFeb 23, 2012
  2. Luke DiamandFeb 23, 2012
  3. Jeff KingFeb 23, 2012
  4. Johannes SixtFeb 23, 2012
  5. Nikolaj ShurkaevFeb 23, 2012
  6. Jeff KingFeb 23, 2012
  7. Nikolaj ShurkaevFeb 23, 2012
  8. Jakub NarebskiFeb 23, 2012
  9. Nikolaj ShurkaevFeb 23, 2012
  10. Jeff KingFeb 23, 2012
  11. Junio C HamanoFeb 23, 2012
  12. Nikolaj ShurkaevFeb 24, 2012
  13. Jeff KingFeb 24, 2012
  14. Junio C HamanoFeb 24, 2012
  15. Jeff KingFeb 24, 2012
  16. Junio C HamanoFeb 24, 2012
  17. Jeff KingFeb 24, 2012
  18. Nikolaj ShurkaevMar 3, 2012
  19. Jakub NarebskiFeb 24, 2012
  20. Junio C HamanoFeb 24, 2012
  21. Andreas SchwabFeb 23, 2012
  22. Nikolaj ShurkaevFeb 23, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.