Re: [PATCH] t5570: use explicit push refspec

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 15, 2012, 19:20 UTC
Message-ID: <7v7gxg2461.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120415001133.GB32140@ecki>

Clemens Buchacher <drizzd@aon.at> writes:

Show 15 quoted lines

> On Sat, Apr 14, 2012 at 04:40:01PM -0700, Junio C Hamano wrote:
>> Clemens Buchacher <drizzd@aon.at> writes:
>> 
>> > The default mode for push without arguments will change. Some warnings
>> > are about to be enabled for such use, which causes some t5570 tests to
>> > fail because they do not expect this output. Fix this by passing an
>> > explicit refspec to git push.
>> 
>> I wonder if a better fix is to configure "push.default = matching" in the
>> test repository.  Otherwise wouldn't the result of the push change once
>> the default changes?
>
> The push.default option matters only if a refspec is not specified. By
> adding a refspec, push.default should not matter any more. Unless that
> is going to change as well?

No, I was thinking more about testing cases where there is no refspec on the command line, which we used to test, but with your patch we no longer do. In other words, your fix not just squelches the advice message and make them pass, but it changes the way the command behaves, no?

Besides, that way you do not have to swap the parameters to test_remote_error so we do not have scratch our heads wondering why we have changes to test vectors that run clones and fetches.