git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jan 2013, #06; Mon, 14)

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 16, 2013, 02:37 UTC
Message-ID
<7v7gnd26pr.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAOkDyE_a4R7=A318VL2TxDn6X8Tu2+m2KNWWYqwBbygRrALQzg@mail.gmail.com>
Adam Spiers <git@adamspiers.org> writes:
Show 21 quoted lines
> On Mon, Jan 14, 2013 at 10:23 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> * as/check-ignore (2013-01-10) 12 commits
>>   (merged to 'next' on 2013-01-14 at 9df2afc)
>>  + t0008: avoid brace expansion
>>  + add git-check-ignore sub-command
>>  + setup.c: document get_pathspec()
>>  + add.c: extract new die_if_path_beyond_symlink() for reuse
>>  + add.c: extract check_path_for_gitlink() from treat_gitlinks() for reuse
>>  + pathspec.c: rename newly public functions for clarity
>>  + add.c: move pathspec matchers into new pathspec.c for reuse
>>  + add.c: remove unused argument from validate_pathspec()
>>  + dir.c: improve docs for match_pathspec() and match_pathspec_depth()
>>  + dir.c: provide clear_directory() for reclaiming dir_struct memory
>>  + dir.c: keep track of where patterns came from
>>  + dir.c: use a single struct exclude_list per source of excludes
>>
>>  Add a new command "git check-ignore" for debugging .gitignore
>>  files.
>
> The above is v4 plus the "t0008: avoid brace expansion" fix.  v4 is
> slightly outdated and not quite the right version to merge to 'next'.
Sigh.

The "What's cooking" is a report of what _has_ already happened. I would have appreciated if you said the above _before_ this happened.

> I'll post a v5 re-roll as per:

Now the series is in 'next', it is too late to _replace_ it X-<. Could you instead make an incremental updates on top? That way, we do not have to re-review the whole thing; we only need to review the changes relative to the old one, making sure that the fixes in the updates are better than the v4 version.

Thanks.
Previous: Adam SpiersNext: Adam Spiers
Message 5 of 9 in “What's cooking in git.git (Jan 2013, #06; Mon, 14)”
  1. Junio C HamanoJan 14, 2013
  2. Junio C HamanoJan 15, 2013
  3. Chris RorvickJan 15, 2013
  4. Adam SpiersJan 16, 2013
  5. Junio C HamanoJan 16, 2013
  6. Adam SpiersJan 16, 2013
  7. clean.c, ls-files.c: respect encapsulation of exclude_list_groupsAdam Spiers, Jan 16, 2013
  8. Junio C HamanoJan 16, 2013
  9. Junio C HamanoJan 16, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.