Re: [PATCH] Honor configure's htmldir switch

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 3, 2013, 01:27 UTC
Message-ID: <7v7gmqb30p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130202212504.GA16412@gmail.com>

"Christoph J. Thompson" <cjsthompson@gmail.com> writes:

Show 21 quoted lines

> Honor autoconf's --htmldir switch. This allows relocating HTML docs 
> straight from the configure script.
>
>
> Signed-off-by: Christoph J. Thompson <cjsthompson@gmail.com>
> ---
>  config.mak.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/config.mak.in b/config.mak.in
> index e8a9bb4..d7c49cd 100644
> --- a/config.mak.in
> +++ b/config.mak.in
> @@ -19,6 +19,7 @@ template_dir = @datadir@/git-core/templates
>  sysconfdir = @sysconfdir@
>  
>  mandir = @mandir@
> +htmldir = @htmldir@
>  
>  srcdir = @srcdir@
>  VPATH = @srcdir@

Hmph, in the output of "git grep -e mandir config.mak.in", I see

    export exec_prefix mandir

which makes me wonder if we should either export htmldir as well, or drop mandir from the "export". Off-hand, I am not sure which is the right way, but in either case the inconsistency disturbs me.

Thanks.