git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 4/5] Git.pm: add interface for git credential command

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 7, 2013, 23:38 UTC
Message-ID
<7v7gmj66fq.fsf@alter.siamese.dyndns.org>
In-Reply-To
<vpq38x8m06f.fsf@grenoble-inp.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 13 quoted lines
> Michal Nazarewicz <mpn@google.com> writes:
>
>> From: Michal Nazarewicz <mina86@mina86.com>
>>
>> Add a credential() function which is an interface to the git
>> credential command.  The code is heavily based on credential_*
>> functions in <contrib/mw-to-git/git-remote-mediawiki>.
>
> I'm no perl expert, so I cannot comment much on style (there are many
> small changes compared to the mediawiki code that look like improvement
> though), but:
>
> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>

Thanks. I'd actually be more worried about the error checking issue Peff raised during his review. I have a feeling that "when in doubt, do not cause harm" is a more prudent way to go than "I do not know, so I'll let anything pass".

Previous: Matthieu MoyNext: Michal Nazarewicz
Message 7 of 11 in “[PATCHv2 0/5] Make git-send-email use git-credential”
  1. Michal NazarewiczFeb 7, 2013
  2. 1/5 Git.pm: allow command_close_bidi_pipe to be called as methodMichal Nazarewicz, Feb 7, 2013
  3. 2/5 Git.pm: fix example in command_close_bidi_pipe documentationMichal Nazarewicz, Feb 7, 2013
  4. 3/5 Git.pm: allow pipes to be closed prior to calling command_close_bidi_pipeMichal Nazarewicz, Feb 7, 2013
  5. 4/5 Git.pm: add interface for git credential commandMichal Nazarewicz, Feb 7, 2013
  6. Matthieu MoyFeb 7, 2013
  7. Junio C HamanoFeb 7, 2013
  8. Michal NazarewiczFeb 8, 2013
  9. Jeff KingFeb 8, 2013
  10. 5/5 git-send-email: use git credential to obtain passwordMichal Nazarewicz, Feb 7, 2013
  11. Junio C HamanoFeb 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.