Re: [PATCH] transport-helper: barf when user tries old:new

From: Junio C Hamano <gitster@pobox.com>
Date: May 21, 2013, 16:32 UTC
Message-ID: <7v7gisqonp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1369098165-8727-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 14 quoted lines

> Otherwise with certain remote helpers (the ones that support 'export'),
> the users will be pushing to the wrong branch:
>
>   git push topic:master
>
> Will push the topic branch, as if the user typed:
>
>   git push topic
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>
> I won't
> bother rationalizing if this makes sense for 'master'

As this is a change to an old code/behaviour that was with us with many released versions, it hardly is for 'master' during -rc period.

I think your dry-run one (the reroll) is a good fix but for the same reason I'd rather see us apply after 1.8.3 final.