git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-pull-script hates me

From
Junio C Hamano <junkio@cox.net>
Date
Jul 6, 2005, 21:23 UTC
Message-ID
<7v64vnwrwg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.58.0507061335100.4159@g5.osdl.org>
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:

LT> But yeah, it's being a bit too anal. Just look at connect.c: shell_safe(), LT> and add both '_' and '@' to the safe list (and any other safe characters), LT> and off you go.

LT> And if somebody wants to add code to do proper escaping of the non-safe LT> ones, we can do that too. I was just lazy and added the characters I ever LT> use ;)

Anybody who is interested in doing this can just move sq_expand() from diff.c to some public library and expose it in cache.h.

I am not going to do it myself immediately so there is no worry to race against me ;-).

Previous: Linus TorvaldsNext: Linus Torvalds
Message 6 of 10 in “git-pull-script hates me”
  1. Greg KHJul 6, 2005
  2. Linus TorvaldsJul 6, 2005
  3. Greg KHJul 6, 2005
  4. Greg KHJul 6, 2005
  5. Linus TorvaldsJul 6, 2005
  6. Junio C HamanoJul 6, 2005
  7. Linus TorvaldsJul 6, 2005
  8. Make sq_expand() available as sq_quote().Junio C Hamano, Jul 8, 2005
  9. Make sq_expand() available as sq_quote().Junio C Hamano, Jul 8, 2005
  10. Use sq_quote() to properly quote the parameter to call shell.Junio C Hamano, Jul 8, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.