Re: RFC: s/git-merge-base/git-find-common-ancestor/g

From: Junio C Hamano <junkio@cox.net>
Date: Sep 11, 2005, 07:38 UTC
Message-ID: <7v64t8xddr.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <874q8s6q9w.wl@mail2.atmark-techno.com>

Yasushi SHOJI <yashi@atmark-techno.com> writes:

Show 12 quoted lines

> I've already got used to it. but, at first, the name gave me the
> impression that it merge the current branch with given base point.
>
> the current documentation says:
>
>    Finds as good a common ancestor as possible for a merge
>
> so would it be better to rename it to:
>
>    git-find-common-ancestor
>
> That's what the command does after all.

It does not find just any common ancestor, but tries to find a set of common ancestors that are good to be used as merge bases. So git-find-merge-base _might_ be an acceptable rename, but git-find-common-ancestor certainly isn't.