Re: [PATCH] [RFC] Make git-update-ref invoke the update and post-update hooks

From: Junio C Hamano <junkio@cox.net>
Date: Oct 8, 2006, 05:00 UTC
Message-ID: <7v64evpfkf.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061008000808.1128.36962.stgit@machine.or.cz>

Petr Baudis <pasky@suse.cz> writes:

Show 8 quoted lines

> Someone raised a concern that the update and post-update hooks are not
> invoked at fetch time in the similar way as they are invoked at push
> time, and the idea sort of makes sense. But this patch goes further - it
> makes Git invoke those hooks each time a ref is updated in a repository
> using the git-update-ref command, which I believe makes a lot of sense as
> well - the behaviour is consistent with the current pushing behaviour
> and you suddenly finally get a hook where you can properly notify even
> about fast-forwards etc.

In principle I do not have problem with this approach per-se, but I wonder if we were to do this we might want to make receive-pack.c::update() and cmd_update_ref() call the same underlying function, and make that underlying function implement this "ask the hook if updating is ok" dance. It might even make sense to have update-ref honor deny_non_fast_forwards for that matter (I am mildly doubtful of this last point, though).