Re: git tag: don't complain of empty messages

From: Junio C Hamano <junkio@cox.net>
Date: Nov 15, 2006, 18:23 UTC
Message-ID: <7v64dgo9gj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <ejfc1t$6am$1@sea.gmane.org>

Han-Wen Nienhuys <hanwen@xs4all.nl> writes:

Show 19 quoted lines

> Hello,
>
> GIT refuses to set annotated tags without a comment. I think this is a
> silly restriction when the message is explicitly set to the empty
> string.
>
> The attached patch should fix this;  Unfortunately, I've been unable
> to test it. Running the script with sh -x stops at
>
> ++exec /home/hanwen/usr/pkg/git/bin/git-sh-setup
>
> -- 
>  Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
> commit 446cfbd9edcfaf5fe76f597823e0e3314d091489
> Author: Han-Wen Nienhuys <hanwen@lilypond.org>
> Date:   Wed Nov 15 16:27:27 2006 +0100
>
>     always set tag if -m is given, even if empty
>

Please follow Documentation/SubmittingPatches.

Show 20 quoted lines

> diff --git a/git-tag.sh b/git-tag.sh
> index ac269e3..f2533a3 100755
> --- a/git-tag.sh
> +++ b/git-tag.sh
> @@ -5,6 +5,7 @@ USAGE='-l [<pattern>] | [-a | -s | -u <k
>  SUBDIRECTORY_OK='Yes'
>  . git-sh-setup
>  
> +message_given=
>  annotate=
>  signed=
>  force=
> @@ -37,6 +38,7 @@ do
>      	annotate=1
>  	shift
>  	message="$1"
> +	message_given=1
>  	;;
>      -u)
>  	annotate=1

If you are going to do this, this hunk should be changed to check if the command line ended with "-m" without next parameter, in which case it should error out.

I do not have a strong objection against allowing tags without messages, but at the same time I do not see a compelling reason to allow them either. Care to explain what workflow is helped by an empty tag?