Re: [PATCH] Skip excessive blank lines before commit body

From: Junio C Hamano <junkio@cox.net>
Date: Jan 3, 2007, 17:03 UTC
Message-ID: <7v64booxfc.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11678312532251-git-send-email-hjemli@gmail.com>

Lars Hjemli <hjemli@gmail.com> writes:

Show 6 quoted lines

> This modifies pretty_print_commit() to make the output of
> git-rev-list and friends a bit more predictable.
>
> A commit body starting with blank lines might be unheard-of,
> but still possible to create using git-commit-tree (so is
> bound to appear somewhere, sometime).

This is unfortunately (!!) a good change. By design, commit-tree should take whatever binary garbage the user throws at it as-is (there is no requirement for it to be even text), and the "punchline + LF + body + LF + signoffs" is strictly by convention. We already reformat using indentations and friends, so your change is a very sane thing to do.

We might want to tighten the formatting convention enforced at the Porcelain level -- we can start the process by shipping a sample commit message hook that checks a well formatted commit log message, perhaps?