Re: [PATCH] update-hook: remove all functionality that should be in hooks/post-receive

From: Junio C Hamano <junkio@cox.net>
Date: Mar 24, 2007, 01:09 UTC
Message-ID: <7v648ro3a3.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200703231022.00189.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 8 quoted lines

> Now that we have a post-receive hook; the update hook's only job is to
> decide is a particular update is allowed or not.
>
> This example hook removes all of the functionality that should now
> rightly be done by the post-receive hook.  In particular: the generation
> of notification emails.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>

I was quite impressed by seeing what Shawn did with his 'continuous' stuff, not the way it is implemented, but the way it was presented as "you can do this to use it from your hook script".

You know what? I am very tempted to take this patch, while dropping the other one. Well, dropping is probably not quite accurate, because being a nice person (and I am good looking, too ;-), I would probably end up creating "contrib/mailhook/" hierarchy and stash the contents of your second patch there myself.

I think I'd better let fancier hooks live in contrib/examples hierarchy for people to pick and choose, and keep the default templates/ directory lean and clean.

There is a small detail of how users who use prepackaged git would get rich library of example hooks from, but that is something better left to distro people; that way I do not have to worry about them too much, and it would also make it crystal clear that these are just examples.

The thing is, not many people are interested in sending e-mail out from post- any hooks (I don't do so, Linus doesn't either), and there is no strong justifiation to give e-mail sending users any preferential treatment and penalize others by copying rather huge hook scripts from templates/ that they are not going to ever use.