Re: [PATCH] [TRIVIAL] Change default man page path to /usr/share/man

From: Junio C Hamano <junkio@cox.net>
Date: May 11, 2007, 19:27 UTC
Message-ID: <7v646zb1p4.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200705112025.58095.ismail@pardus.org.tr>

Ismail Dönmez <ismail@pardus.org.tr> writes:

Show 11 quoted lines

> On Tuesday 08 May 2007 13:49:31 you wrote:
>> Hi,
>>
>> According to FHS standard default man page path is $prefix/share/man [0] ,
>> attached patch fixes this for GIT.
>>
>> [0] http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREMANMANUALPAGES
>>
>> Signed-off-by: Ismail Donmez <ismail@pardus.org.tr>
>
> ACK? NAK? Do we care about this? :)

I would not say the patch is wrong per-se, but:

 - People who do not override prefix to install in $HOME would
   suddenly get their mandir under $HOME/share/man; the fact
   nobody complained so far suggests me that these people have
   $MANPATH pointing at $HOME/man, which means your patch breaks
   things for them, unless they have been overriding mandir in
   which case your patch does not matter to them;

 - Distros who package git and want to conform to FHS would have
   been overriding not just prefix but mandir anyway, so your patch
   is not an improvement to them;

 - People who override prefix to install locally in /usr or
   /usr/local does "make prefix=" thing anyway, and the fact
   nobody complained so far suggests me that they have already
   known they need to override mandir as well if they do not
   like /usr/local/man, so your patch is not an improvement to
   them.

That makes one half negative plus two and half neutral.