Re: [install info (using perl) 1/2] Add support for an info version of the user manual

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 8, 2007, 23:05 UTC
Message-ID: <7v643p1vbr.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vabt11vkj.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <gitster@pobox.com> writes:

Show 20 quoted lines

> David Kastrup <dak@gnu.org> writes:
>
>> @@ -139,6 +154,18 @@ XSLTOPTS = --xinclude --stringparam html.stylesheet docbook-xsl.css
>>  user-manual.html: user-manual.xml
>>  	xsltproc $(XSLTOPTS) -o $@ $(XSLT) $<
>>  
>> +git.info: user-manual.xml
>> +	$(RM) $@ $*.texi
>> +	$(DOCBOOK2X_TEXI) user-manual.xml --to-stdout | \
>> +	perl -ne 'if (/^\@setfilename/) {$$_="\@setfilename git.info\
>> +"} elsif (/^\@direntry/) {print "\@dircategory Development\
>> +\@direntry\
>> +* Git: (git).           A fast distributed revision control system\
>> +\@end direntry\
>> +"} print unless (/^\@direntry/ .. /^\@end direntry/)' > $*.texi
>> +	$(MAKEINFO) --no-split $*.texi
>> +	$(RM) $*.texi
>> +
>
> This part worries me.

Aside from possible portability issue of multi-line script, there is another slight problem I am not sure if it is worth fixing. If you do not have docbook2x-texi installed, nobody notices that resulting $*.texi was a garbage and an almost empty git.info is generated.