Re: [PATCH 1/3] Add an optional <mode> argument to commit/status -u|--untracked-files option

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 10, 2008, 06:23 UTC
Message-ID: <7v63sherlb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <484CD3A7.8090303@trolltech.com>

Marius Storm-Olsen <marius@trolltech.com> writes:

> Ops, obviously it should have been s@\(int\)@(intptr_t)@. Sorry about
> that, I'll resend the patch series.

Requeued.

Show 5 quoted lines

> (The option struct in parse_options.h uses intptr_t for the default
> value of an option, thus a normal const char * would make the compiler
> complain (verified with both Windows MinGW 3.4.5 and Linux GCC 4.1.2))
>
> BTW, which compiler version are you using?

    gcc (GCC) 4.2.3 20071014 (prerelease) (Debian 4.2.2-3)
    Copyright (C) 2007 Free Software Foundation, Inc.
    This is free software; see the source for copying conditions.  There is NO
    warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

but with -Wold-style-definition -Werror -std=c99 -Wno-pointer-to-int-cast -Wdeclaration-after-statement etc.