git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: call 'fatal' correctly in set-tree

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 12, 2008, 05:34 UTC
Message-ID
<7v63nyidgx.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1222696698-97356-1-git-send-email-luc@honk-honk.com>
Luc Heinrich <luc@honk-honk.com> writes:
Show 24 quoted lines
> When doing a set-tree and there is no revision to commit to, the
> following unrelated error message is displayed: "Undefined subroutine
> &Git::SVN::fatal called at /opt/local/libexec/git-core/git-svn line
> 2575." The following patch fixes the problem and allows the real error
> message to be shown.
>
> Signed-off-by: Luc Heinrich <luc@honk-honk.com>
> ---
>  git-svn.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 80a5728..7609a83 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2591,7 +2591,7 @@ sub set_tree {
>  	my ($self, $tree) = (shift, shift);
>  	my $log_entry = ::get_commit_entry($tree);
>  	unless ($self->{last_rev}) {
> -		fatal("Must have an existing revision to commit");
> +		::fatal("Must have an existing revision to commit");
>  	}
>  	my %ed_opts = ( r => $self->{last_rev},
>  	                log => $log_entry->{log},

Shouldn't the same change be done for the fatal call from apply_diff in SVN::Git::Editor package?

Previous: Luc Heinrich
Message 2 of 2 in “git-svn: call 'fatal' correctly in set-tree”
  1. git-svn: call 'fatal' correctly in set-treeLuc Heinrich, Sep 29, 2008
  2. Junio C HamanoOct 12, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.