Re: Make Gitweb behave like Apache mod_userdir

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 17, 2009, 23:40 UTC
Message-ID: <7v6398btz4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7fce93be0911171454i61e995a1ob0bf80013bcb0727@mail.gmail.com>

Sylvain Rabot <sylvain@abstraction.fr> writes:

Show 15 quoted lines

> On Tue, Nov 17, 2009 at 23:10, Junio C Hamano <gitster@pobox.com> wrote:
>> Sylvain Rabot <sylvain@abstraction.fr> writes:
>>
>>>> Wouldn't it be a good idea to somehow make this work well together with
>>>> the --user-path feature of git-daemon?
>>>>
>>>> Perhaps the recommended name given in the example shouldn't be ~/gitweb,
>>>> but more like ~/public_git, as this is like ~/public_html but for git
>>>> repositories.  Then the end users will browse
>>>
>>> As I said, it's configuration :)
>>
>> Wrong answer.
>
> Am I passing a test ?

Sorry, but that wasn't what I meant.

Show 8 quoted lines

>> Exactly because it is configurable, the document that outlines the
>> recommended practice should suggest the best convention.  My point was
>> that it is likely to be tied to "git"-ness of the specified directory
>> under $HOME/, not limited to "gitweb"-ness, and it is wrong to recommend a
>> name tied to "gitweb"-ness in this document.
>
> Again, git is a brand new world for me and I don't know any of his
> conventions yet.

I do not see this as git-specific conventions.

But suggesting ~/gitweb is perfectly excusable, especially if you did not know that git-daemon can respond to "git://host/~user/".

John warthog19 (hmm, I thought he used to be warthog9) explained the above much better than I did. People tend to cut and paste without thinking, so we should describe a good default layout in our documentation.

> I am not trying to impose my own conventions, I am just proposing an idea.

Yeah, I know. We are all in this to improve things for people who follow us.