Re: [PATCH] Add `log.decorate' configuration variable.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 17, 2010, 08:14 UTC
- Message-ID
- <7v635w5ldv.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <alpine.LNX.2.00.1002171950040.8560@vqena.qenxr.bet.am>
Steven Drake <sdrake@xnet.co.nz> writes:
> Have you commited the git_config_maybe_bool() code?
Not yet, but now you mention it, it probably is a good idea to make the "maybe" part a separate patch, independent from log.decorate. It should be useful elsewhere, I guess.
> By the way is it alright to send patches that use inbody-headers and/or > scissors?
If used judiciously, i.e. when it makes it easier to follow the discussion. It would sometimes make an important patch more likely to get buried in a deep thread, though.