Re: [PATCH 09/11] streaming: read non-delta incrementally from a pack
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 16, 2011, 05:00 UTC
- Message-ID
- <7v62pbnssd.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <BANLkTin7DALU8sfFxzJo62DGtNE2fsZxXw@mail.gmail.com>
Shawn Pearce <spearce@spearce.org> writes:
Show 5 quoted lines
> On Sun, May 15, 2011 at 17:30, Junio C Hamano <gitster@pobox.com> wrote: >> +static read_method_decl(pack_non_delta) > > I am not a huge fan of these decl macros... but I can see how writing > out the same function prototype 3 times is annoying.
More importantly, it helped greatly while re-rolling this series literally several times until I nailed the right set of parameters these methods should take.
> I think the better strategy is to avoid delta compression altogether > for objects that are so big we cannot materialize them as a contiguous > buffer.
Yes, that is what I am aiming for in the recent topics around this area.