Re: [PATCH] gitweb: allow space as delimiter in mime.types

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 14, 2011, 21:28 UTC
Message-ID: <7v62o8ksq5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <m3ips8v4s2.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

Show 6 quoted lines

> Ludwig Nussel <ludwig.nussel@suse.de> writes:
>
>> Subject: [PATCH] gitweb: allow space as delimiter in mime.types
>
> A very minor nitpick: perhaps "work with" rather than "allow" would be
> better?

Allow is good; we earlier didn't allow space to be treated as delimiter, with this patch we will do.

Show 13 quoted lines

>> in openSUSE /etc/mime.types has only spaces. I don't know if there's
>> a canonical reference that says that only tabs are allowed. Mutt at
>> least also accepts spaces. So make gitweb more liberal too.
>
> Ack.
>
> It is obviously correct, as names of MUME types cannot contain spaces,
> it makes gitweb work with openSUSE /etc/mime.types, and it makes code
> simpler.
>
>> ---
>
> Signoff (i.e. Signed-off-by)?

Yes, sign-off is missing and necessary.

Thanks.