git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3] ref namespaces: tests

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 21, 2011, 21:56 UTC
Message-ID
<7v62mux9ae.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110721201054.GA2530@leaf>
Josh Triplett <josh@joshtriplett.org> writes:
> At this point I think we've incorporated all the outstanding feedback.
> Does this test need any further changes to allow the ref-namespaces
> branch to graduate to next?
No more nitpicks from me on this patch at least for now.

Are people who expressed concern during the review on the previous round of the series happy with the second round? I recall there was a strong sentiment that it is regrettable that the series specifically changes fetch and push and is not a more general mechanism. Personally I am OK with the approach taken by this series, as I do not offhand think of other ways to serve a modified namespace. You have to view the unaltered reality when interacting with your own refs to enumerate the objects you have, while giving the altered view to your clients that is limited to the "virtual" space.

> (Also, for future reference, do you prefer to see later versions of
> patches as replies to the previous version, as I've made this mail a
> reply to PATCHv2, or do you prefer to see them as new threads?)

Often it is very convenient to be able to go "up" in the thread to re-read the discussions in the previous round. On the other hand it sometimes gets inconvenient when viewing tons of threads to have a beginning of a new round buried deep in other threads. Referring to the messages in the previous round by their message-id (or thread.gmane.org/ URL) in the body of the patch message below "---" lines may solve both issues, but I can go either way.

Previous: Josh TriplettNext: Jeff King
Message 6 of 8 in “ref namespaces: tests”
  1. ref namespaces: testsJosh Triplett, Jul 14, 2011
  2. Junio C HamanoJul 14, 2011
  3. Josh TriplettJul 15, 2011
  4. [PATCHv2] ref namespaces: testsJosh Triplett, Jul 15, 2011
  5. [PATCHv3] ref namespaces: testsJosh Triplett, Jul 21, 2011
  6. Junio C HamanoJul 21, 2011
  7. Jeff KingJul 22, 2011
  8. Junio C HamanoJul 15, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.