Re: [PATCH] format-patch: cover letter does not respect i18n.commitencoding

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2011, 19:24 UTC
Message-ID: <7v62kn6mqi.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1316507177-6403-1-git-send-email-zapped@mail.ru>

Alexey Shumkin <zapped@mail.ru> writes:

Show 10 quoted lines

> diff --git a/builtin/log.c b/builtin/log.c
> index 5c2af59..6a4050c 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -769,7 +769,7 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,
>  	struct shortlog log;
>  	struct strbuf sb = STRBUF_INIT;
>  	int i;
> -	const char *encoding = "UTF-8";
> +	const char *encoding =  get_commit_output_encoding();

Hmm, I have a feeling that this should use log output encoding. Am I mistaken?

The i18n.commitencoding variable is about the internal representation in the object [*1*] that is to be converted from the encoding of the original e-mail message which could be different. i18n.logoutputencoding is to externalize it [*2*].

[Footnotes]

*1* f1f909e (mailinfo: Use i18n.commitencoding, 2005-11-27) *2* a731ec5 (t3901: test "format-patch | am" pipe with i18n, 2007-01-13)