Re: What's cooking in git.git (Oct 2011, #04; Wed, 12)

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 12, 2011, 19:05 UTC
Message-ID: <7v62ju9gjc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111012190213.GA19578@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> On Wed, Oct 12, 2011 at 11:48:48AM -0700, Junio C Hamano wrote:
>
>> * jk/name-hash-dirent (2011-10-07) 1 commit
>>   (merged to 'next' on 2011-10-11 at e2ea68b)
>>  + fix phantom untracked files when core.ignorecase is set
>
> I didn't see any comment on the original patch, so I assume you're OK
> with the few extra bytes added to each cache entry? Otherwise, I can try
> to retool it to keep the directory entries in a separate hash, so only
> case-insensitive people pay the extra price.
>
> I did a few trivial timings, and the extra bytes didn't seem to make any
> difference.

I tend to agree with you that 8 extra bytes per cache entry wouldn't hurt. I also suspected that the cost of code complexity coming from both maintaining and conditionally looking up a separate hash would outweigh the benefit.