git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: Fix %config_path_settings handling

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 14, 2011, 23:23 UTC
Message-ID
<7v62jrxim1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<201110142253.32695.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 5 quoted lines
> From: Cord Seele <cowose@gmail.com>
> ...
> Signed-off-by: Cord Seele <cowose@gmail.com>
> Tested-by: Michael J Gruber <git@drmicha.warpmail.net>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Thanks.
Show 37 quoted lines
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 579ddb7..87b4acc 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -1168,4 +1168,32 @@ test_expect_success $PREREQ '--force sends cover letter template anyway' '
>  	test -n "$(ls msgtxt*)"
>  '
>  
> +test_expect_success $PREREQ 'sendemail.aliasfiletype=mailrc' '
> +	clean_fake_sendmail &&
> +	echo "alias sbd  somebody@example.org" >.mailrc &&
> +	git config --replace-all sendemail.aliasesfile "$(pwd)/.mailrc" &&
> +	git config sendemail.aliasfiletype mailrc &&
> +	git send-email \
> +	  --from="Example <nobody@example.com>" \
> +	  --to=sbd \
> +	  --smtp-server="$(pwd)/fake.sendmail" \
> +	  outdir/0001-*.patch \
> +	  2>errors >out &&
> +	grep "^!somebody@example\.org!$" commandline1
> +'
> +
> +test_expect_success $PREREQ 'sendemail.aliasfile=~/.mailrc' '
> +	clean_fake_sendmail &&
> +	echo "alias sbd  someone@example.org" >~/.mailrc &&
> +	git config --replace-all sendemail.aliasesfile "~/.mailrc" &&
> +	git config sendemail.aliasfiletype mailrc &&
> +	git send-email \
> +	  --from="Example <nobody@example.com>" \
> +	  --to=sbd \
> +	  --smtp-server="$(pwd)/fake.sendmail" \
> +	  outdir/0001-*.patch \
> +	  2>errors >out &&
> +	grep "^!someone@example\.org!$" commandline1
> +'
> +
>  test_done
Previous: Jakub Narebski
Message 11 of 11 in “[BUG] send-email: alias expansion broken”
  1. Michael J GruberOct 14, 2011
  2. fix alias expansion with new Git::config_path()Cord Seele, Oct 14, 2011
  3. Michael J GruberOct 14, 2011
  4. Cord SeeleOct 14, 2011
  5. Junio C HamanoOct 14, 2011
  6. Jakub NarebskiOct 14, 2011
  7. Junio C HamanoOct 14, 2011
  8. send-email: Fix %config_path_settings handlingJakub Narebski, Oct 14, 2011
  9. Junio C HamanoOct 14, 2011
  10. Jakub NarebskiOct 14, 2011
  11. Junio C HamanoOct 14, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.