Re: [PATCHv2] git bisect old/new
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 15, 2012, 21:06 UTC
- Message-ID
- <7v62as9tex.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CABURp0qGUvjtOBp8vQ4LqWsWp-5oi+-2GwVq-edQbUnKzXHR-A@mail.gmail.com>
Phil Hord <phil.hord@gmail.com> writes:
Show 5 quoted lines
> Except that most of the work to support <arbitrary1/arbitrary2> is > already being done in this patch to add <new/old>, but it will need > re-doing or un-doing to move to arbitrary terms. Supporting arbitrary > terms today would save work (the re-doing and the un-doring), if we > went that way in the future.
You are forgetting that "somebody wrote the code" does not matter much. What counds more is that the code is more complex than necessary to support the case we are immediately interested in, which means it is much more likely to have undiscovered bugs and will take more effort to update if we need to change the aspects other than "arbitrary two tokens" later. "Somebody wrote the code already" matters only when we are sure that we want to build on top of it. In this case, we don't.