Re: [PATCH 1/5] Import wildmatch from rsync

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 16, 2012, 06:49 UTC
Message-ID: <7v627ezcm9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1347710524-15404-2-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> These files are from rsync.git commit
> d51a3adb4fca3e6b1b046c6e570828f3bca8fe36. The commit is GPL-3. However
> wildmatch.[ch] have not changed since rsync turned to GPL-3.

I'd like see the last version of rsync that was GPLv2 hunted down and the copy from that version lifted from it. If you _know_ they are identical, then you should be able to do that, no?

>  compat/wildmatch.c             | 368 +++++++++++++++++++++++++++++++++++++++++
>  compat/wildmatch.h             |   6 +

As this will be linked on all platforms, it shouldn't be in compat/ directory. Unlike xdiff/ that has many files, this can live at the top-level, just like kwset we borrowed from GNU grep does.

Show 18 quoted lines

> diff --git a/compat/wildmatch.c b/compat/wildmatch.c
> new file mode 100644
> index 0000000..f3a1731
> --- /dev/null
> +++ b/compat/wildmatch.c
> @@ -0,0 +1,368 @@
> +/*
> +**  Do shell-style pattern matching for ?, \, [], and * characters.
> +**  It is 8bit clean.
> +**
> +**  Written by Rich $alz, mirror!rs, Wed Nov 26 19:03:17 EST 1986.
> +**  Rich $alz is now <rsalz@bbn.com>.
> +**
> +**  Modified by Wayne Davison to special-case '/' matching, to make '**'
> +**  work differently than '*', and to fix the character-class code.
> +*/
> +
> +#include "rsync.h"

Huh???

Ahh. The approach you took is "This patch imports the pristine copy to make it easier to verify the provenance, and the plan is to make it usable with separate follow-up patches.", I agree that is a very sensible thing to do.

But please say so in the commit log message.