git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Documentation/githooks: Explain pre-rebase parameters

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 24, 2013, 08:13 UTC
Message-ID
<7v621i6sey.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130223213513.GF1361@odin.tremily.us>
"W. Trevor King" <wking@tremily.us> writes:
Show 22 quoted lines
> On Sat, Feb 23, 2013 at 01:21:59PM -0800, Junio C Hamano wrote:
>> "W. Trevor King" <wking@tremily.us> writes:
>> 
>> > +This hook is called by 'git rebase' and can be used to prevent a
>> > +branch from getting rebased.  The hook takes two parameters: the
>> > +upstream the series was forked from and the branch being rebased.  The
>> > +second parameter will be missing when rebasing the current branch.
>> 
>> takes one or two parameters?
>>
>> Other than that, looks good to me, but it took me two readings to
>> notice where these two parameters are described.  I have a feeling
>> that a comma s/forked from and/forked from, and/; might make them a
>> bit more spottable, but others may have better suggestions to make
>> them stand out more.
>
> How about:
>
>   The hook may be called with one or two parameters.  The first
>   parameter is the upstream from which the series was forked.  The
>   second parameter is the branch being rebased, and is not set when
>   rebasing the current branch.
Much nicer.  Thanks.
Previous: W. Trevor King
Message 11 of 11 in “Documentation/githooks: Explain pre-rebase parameters”
  1. Documentation/githooks: Explain pre-rebase parametersW. Trevor King, Feb 19, 2013
  2. Thomas RastFeb 19, 2013
  3. W. Trevor KingFeb 19, 2013
  4. Junio C HamanoFeb 19, 2013
  5. Junio C HamanoFeb 19, 2013
  6. W. Trevor KingFeb 20, 2013
  7. Junio C HamanoFeb 20, 2013
  8. Documentation/githooks: Explain pre-rebase parametersW. Trevor King, Feb 23, 2013
  9. Junio C HamanoFeb 23, 2013
  10. W. Trevor KingFeb 23, 2013
  11. Junio C HamanoFeb 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.