Re: [PATCH v10 3/5] t4205, t6006, t7102: make functions better readable

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 5, 2013, 18:45 UTC
Message-ID: <7v61wo7sm7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7va9m07syh.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> Alexey Shumkin <alex.crezoff@gmail.com> writes:
>
>> -	msg=$(printf "modify 2nd file (ge\303\244ndert)")
>> +	msg="modify 2nd file (ge\303\244ndert)"
>>  	if test -n "$1"
>>  	then
>> -		msg=$(echo $msg | iconv -f utf-8 -t $1)
>> +		print "$msg" | iconv -f utf-8 -t "$1"
>> +	else
>> +		print "$msg"
>>  	fi
>> -	echo $msg
>>  }
>
> I think I'll do s/print/&f/ before queuing this.

Also, I'll change the $msg constant to have \n at the end, as we are losing it by bypassing "echo".