git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/6] Reactivate show-diff patch generation

From
Junio C Hamano <junkio@cox.net>
Date
Apr 27, 2005, 06:25 UTC
Message-ID
<7v4qdska7r.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<7vekcwkagr.fsf@assigned-by-dhcp.cox.net>

This patch uses the reworked diff interface to generate patches directly out of show-diff when -p is specified.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

show-diff.c | 56 ++++++++++++++++++++++++++++++++++++++++++-------------- 1 files changed, 42 insertions(+), 14 deletions(-)

To be tested with the following:
    GIT_INDEX_FILE=junk
    export GIT_INDEX_FILE
    rm -f junk
    date >trash ; update-cache --add trash
    date >>trash;
    GIT_EXTERNAL_DIFF=echo ./show-diff -p
    update-cache --refresh
    GIT_EXTERNAL_DIFF=echo ./show-diff -p

--- k/show-diff.c +++ l/show-diff.c

@@ -4,10 +4,11 @@
  * Copyright (C) Linus Torvalds, 2005
  */
 #include "cache.h"
+#include "diff.h"
 
-static const char *show_diff_usage = "show-diff [-q] [-s] [-z] [paths...]";
+static const char *show_diff_usage = "show-diff [-q] [-s] [-z] [-p] [paths...]";
 
-static int recursive = 0;
+static int generate_patch = 0;
 static int line_termination = '\n';
 static int silent = 0;
 static int silent_on_nonexisting_files = 0;
@@ -27,27 +28,57 @@ static int matches_pathspec(struct cache
 	return 0;
 }
 
-static void show_file(const char *prefix, struct cache_entry *ce)
+static void show_unmerge(const char *path)
 {
-	printf("%s%o\t%s\t%s\t%s%c", prefix, ntohl(ce->ce_mode), "blob",
-		sha1_to_hex(ce->sha1), ce->name, line_termination);
+	if (generate_patch)
+		diff_unmerge(path);
+	else
+		printf("U %s%c", path, line_termination);
+}
+
+static void show_file(int pfx, struct cache_entry *ce)
+{
+	if (generate_patch)
+		diff_addremove(pfx, ntohl(ce->ce_mode), ce->sha1,
+			       ce->name, NULL);
+	else
+		printf("%c%06o\t%s\t%s\t%s%c",
+		       pfx, ntohl(ce->ce_mode), "blob",
+		       sha1_to_hex(ce->sha1), ce->name, line_termination);
+}
+
+static void show_modified(int oldmode, int mode,
+			  const char *old_sha1, const char *sha1,
+			  char *path)
+{
+	char old_sha1_hex[41];
+	strcpy(old_sha1_hex, sha1_to_hex(old_sha1));
+
+	if (generate_patch)
+		diff_change(oldmode, mode, old_sha1, sha1, path, NULL);
+	else
+		printf("*%06o->%06o\tblob\t%s->%s\t%s%c",
+		       oldmode, mode, old_sha1_hex, sha1_to_hex(sha1), path,
+		       line_termination);
 }
 
 int main(int argc, char **argv)
 {
-	static const char null_sha1_hex[] = "0000000000000000000000000000000000000000";
+	static const char null_sha1[20] = { 0, };
 	int entries = read_cache();
 	int i;
 
 	while (1 < argc && argv[1][0] == '-') {
 		if (!strcmp(argv[1], "-s"))
 			silent_on_nonexisting_files = silent = 1;
+		else if (!strcmp(argv[1], "-p"))
+			generate_patch = 1;
 		else if (!strcmp(argv[1], "-q"))
 			silent_on_nonexisting_files = 1;
 		else if (!strcmp(argv[1], "-z"))
 			line_termination = 0;
 		else if (!strcmp(argv[1], "-r"))
-			recursive = 1;		/* No-op */
+			; /* no-op */
 		else
 			usage(show_diff_usage);
 		argv++; argc--;
@@ -72,8 +103,7 @@ int main(int argc, char **argv)
 			continue;
 
 		if (ce_stage(ce)) {
-			printf("U %s%c", ce->name, line_termination);
-
+			show_unmerge(ce->name);
 			while (i < entries &&
 			       !strcmp(ce->name, active_cache[i]->name))
 				i++;
@@ -88,7 +118,7 @@ int main(int argc, char **argv)
 			}	
 			if (silent_on_nonexisting_files)
 				continue;
-			show_file("-", ce);
+			show_file('-', ce);
 			continue;
 		}
 		changed = cache_match_stat(ce, &st);
@@ -98,10 +128,8 @@ int main(int argc, char **argv)
 		oldmode = ntohl(ce->ce_mode);
 		mode = S_IFREG | ce_permissions(st.st_mode);
 
-		printf("*%o->%o\t%s\t%s->%s\t%s%c",
-			oldmode, mode, "blob",
-			sha1_to_hex(ce->sha1), null_sha1_hex,
-			ce->name, line_termination);
+		show_modified(oldmode, mode, ce->sha1, null_sha1,
+			      ce->name);
 	}
 	return 0;
 }
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 9 in “External diff interface for diff-cache and friends.”
  1. 0/6 External diff interface for diff-cache and friends.Junio C Hamano, Apr 27, 2005
  2. 1/6 Reworked external diff interface.Junio C Hamano, Apr 27, 2005
  3. 2/6 Reactivate show-diff patch generationJunio C Hamano, Apr 27, 2005
  4. 3/6 Add -p (patch) to diff-tree.Junio C Hamano, Apr 27, 2005
  5. 4/6 Add -p (patch) to diff-cache.Junio C Hamano, Apr 27, 2005
  6. 5/6 Teach diff-tree-helper to handle unmerged paths.Junio C Hamano, Apr 27, 2005
  7. 6/6 Alternative patch to diff-cache.cJunio C Hamano, Apr 27, 2005
  8. 7/6 Leftover bits.Junio C Hamano, Apr 27, 2005
  9. Linus TorvaldsApr 27, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.