Re: [PATCH] Add git-imap-send.

From: Junio C Hamano <junkio@cox.net>
Date: Mar 9, 2006, 18:49 UTC
Message-ID: <7v4q275u7m.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0603091017530.18022@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 10 quoted lines

>> > ... They won't be used in the eventual result, but 
>> > just the fact that they are loaded from memory can mean that your program 
>> > takes a SIGSEGV, for example, becaue it turns out "string" was just a 
>> > single NUL byte at the end of a page, and there's nothing after it.
>> 
>> Funny.  I've seen this exact bug in memcmp and strcmp in earlier
>> SunOS (pre Solaris) libc when I was working on something like
>> Valgrind in my previous life.
>
> Well, Valgrind actually can complain for no good reason.

To clarify, it was _not_ Valgrind I was mucking with. And the optimization used in the system library was wrong -- it stepped over the page boundary without checking. I found that it was fixed in later releases (that was all before Sun started calling their system Solaris).