Re: git+ssh://master.kernel.org/home/rmk/linux-2.6-arm.git
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 1, 2006, 08:46 UTC
- Message-ID
- <7v4pww3ktw.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20060801001958.67a071b2.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> writes:
Show 8 quoted lines
> > fyi, a git-fetch of this tree gives: > > error: refs/heads/devel does not point to a valid commit object! > error: refs/heads/devel does not point to a valid commit object! > > Junio, I'm running git-core-1.4.0-1.fc5 - perhaps more recent gits are > better at telling the user if the error is remote or local. If not: whine ;)
I'd try this out and see what people think.
-- >8 -- [PATCH] fetch/clone: mark messages from remote side stand out.
When dealing with a corrupt or out of sync remote repository, the user often gets error messages like this:
error: refs/heads/devel does not point to a valid commit object!
which leaves the user wondering if the breakage is on the local end or on the remote end. This is unnecessarily alarming.
This patch changes the way we display messages received from the remote side over the git protocol sideband (i.e. stderr stream of the remote process). It shows them with blue background with white letters, but this presentation is subject to proposals of better ways from the list.
The problem was pointed out by Andrew Morton.
Signed-off-by: Junio C Hamano <junkio@cox.net> --- fetch-clone.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fetch-clone.c b/fetch-clone.c index 81d1371..692d9b7 100644 --- a/fetch-clone.c +++ b/fetch-clone.c @@ -133,7 +133,10 @@ static pid_t setup_sideband(int sideband fprintf(stderr, "\n"); exit(1); case 2: + /* color sideband */ + safe_write(2, "\033[44;37;1m", 10); safe_write(2, buf+1, len); + safe_write(2, "\033[m", 3); continue; case 1: safe_write(fd[1], buf+1, len);
-- 1.4.2.rc2.gb9f77