git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: fix 2 whitespace issues

From
Junio C Hamano <junkio@cox.net>
Date
Oct 12, 2006, 16:40 UTC
Message-ID
<7v4pu9pjwe.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.63.0610121418180.14200@wbgn013.biozentrum.uni-wuerzburg.de>

I noticed this breakage sometime last week and it was sitting at near the bottom of my stack of things to look at. Ray's bugreport and your fix were quite timely. Thanks.

You mentioned six whitespace problems but I counted only three and the test failed on "CR at the end"; the test vector was easy to hand-fix thanks to the "index" line.

This patch is an example that we do not want to transmit files that has CRs in e-mail. These CRs appear in format-patch output, so either the user needs to do --attach (and perhaps the option needs to do base64 or qp in such a case) or format-patch needs to treat a blob with CR as binary and emit binary diff? The latter is not appropriate since patches apply just fine with CR in them.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 2 of 3 in “diff: fix 2 whitespace issues”
  1. diff: fix 2 whitespace issuesJohannes Schindelin, Oct 12, 2006
  2. Junio C HamanoOct 12, 2006
  3. Johannes SchindelinOct 12, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.