Re: [PATCH] gitweb: Atom feeds
- From
Junio C Hamano <junkio@cox.net>
- Date
- Nov 17, 2006, 09:01 UTC
- Message-ID
- <7v4psysazy.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <ejim5q$31b$1@sea.gmane.org>
Andreas Fuchs <asf@boinkor.net> writes:
Show 19 quoted lines
> Jakub Narebski wrote: >> Andreas Fuchs <asf@boinkor.net> wrote: >> >>> * Wrap the commit message in <pre> >> We use <div class="pre"> in "commit" view if I remember correctly. > > That's ok for rendered HTML output, but in my experience, the way feed > readers interpret that ranges from "badly" to "not at all"; it's better > to stick to explicit structure hints only in feeds. /-: > > So, this is the only thing I haven't fixed in the attached patch (: > ... > In addition to the above points, the attached patch emits a > Last-Changed: HTTP response header field, and doesn't compute the feed > body if the HTTP request type was HEAD. This helps keep the web server > load down for well-behaved feed readers that check if the feed needs > updating. > > Hope you like it,
Seems sane to me. Jakub, how do you like this one? If it looks Ok to you, please arrange to include your one-liner that this depends on and forward a readily applicable patch with appropriate commit log message.