Re: [PATCH 3/4] Teach git-describe to display distances from tags.
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jan 27, 2007, 08:47 UTC
- Message-ID
- <7v4pqcluum.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20070127065413.GC10380@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 14 quoted lines
> Junio C Hamano <junkio@cox.net>: >> However, I suspect that we could do better with Shawn's new >> fangled describe implementation that actually counts the >> distance between what is described and the tag. We could add >> "number of commits since the tag" somewhere, to describe: >> >> v2.6.20-rc5-256-g419dd83 >> v2.6.20-rc5-217-gde14569 > ... > v2.6.20-rc5+256-g419dd83 > v2.6.20-rc5+217-gde14569 > > The + format is much easier to read and understand than the - format > original proposed by Junio.
I tend to disagree (I do not claim + is _less_ easier to read, though).
They are of comparable readability, and I think plus breaks GIT-VERSION-GEN (the primary reason it replaces '-' to '.' is to work around RPM limitation IIRC, and I do not know what '+' does to RPM offhand).
But I do not have a strong feeling either way.