Re: [RFC/PATCH] commit-tree: bump MAX_PARENTS to 128

From: Junio C Hamano <junkio@cox.net>
Date: Feb 27, 2007, 11:06 UTC
Message-ID: <7v4pp7hnbs.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070227105212.GA21757@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Tue, Feb 27, 2007 at 02:23:02AM -0800, Junio C Hamano wrote:
>
>> Although pointers to component project commits are represented
>> as "parent" field in commit objects, I suspect that you wish
>> they were treated as if they were tree objects contained in the
>> toplevel commits more often than not for the purposes of many
>> git operations.
>
> Yes, that is exactly correct. One problem I realized after doing this is
> that you get unexpected results from "git-whatchanged -- subproject/".
> My first expectation was to see _just_ the history of the subproject.
> But of course, you see only the merge commit, since the previous commits
> for that subproject didn't have that path at all (they were in the
> root!).  Subproject support would fix that, as would simply rewriting
> the history.

For the record, I am aware of the fact that the recent git.git itself exhibits this exact problem, due to the subtree merge of git-gui repository. I haven't got to the point of being annoyed enough to regret it, but running "git show" on merges from Shawn always needs -M option to make heads or tails of.