Re: [PATCH] Make the installation targets a little less chatty

From: Junio C Hamano <junkio@cox.net>
Date: Jun 1, 2007, 00:12 UTC
Message-ID: <7v4pls1qjv.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070531222313.GA12204@steel.home>

Alex Riesen <raa.lkml@gmail.com> writes:

Show 8 quoted lines

> by default. V=1 works as usual.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>
> Now it quite quiet. I tried top show every installed file, but it
> wasn't an improvement at all so I decided to just show what's being
> done.

I agree that the long single line that installs the commands to $(bindir) may be somewhat annoying.

Cleaning up compilation step is one thing; by tidying up the output it makes compiler warnings stand out.

But I do not like playing games like this in general in installation rule. An excerpt from your patch:

> +	@echo installing programs
> +	$(QUIET)$(foreach p,$(BUILT_INS), rm -f ...

This would not even let you see what got installed. At least, less verbose compilation step we have these days lets you see what is being built. I certainly would not object if the output would look like this, though:

	CC builtin-cat-file.o
        ...
        GEN git-add--interactive
        ...
        LINK git-http-push
        ...
        BUILTIN git-add
        ...
	MKDIR -p /usr/local/bin
        INSTALL git-foo
        INSTALL git-bar
	...
        INSTALL templates/description
        INSTALL templates/hooks/post-update
        ...