Re: [PATCH] git-cvsserver: handle change type T

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 16, 2008, 22:28 UTC
Message-ID: <7v4pb6gv7x.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <47DD9890.3060005@gnu.org>

Paolo Bonzini <bonzini@gnu.org> writes:

Show 16 quoted lines

> Junio C Hamano wrote:
>> Paolo Bonzini <bonzini@gnu.org> writes:
>>
>>> git-cvsserver does not support changes of type T (file type change,
>>> e.g. symlink->real file).  This patch treats them the same as changes
>>> of type M.
>>
>> Hmm.
>>
>> Do cvs clients even know how to handle symlinks, or will this patch just
>> start sending the readlink(2) result as if it is just a regular file
>> contents?
>
> It was before too.  The problem arises if one found the problem,
> deleted the symlink, added the regular file -- and now cvsserver stops
> working at all. :-(

I fully agree that "stops working at all" was baaaaad, and your patch may be an improvement.

What I am questioning is what the code should do (IOW, what would be good for cvs clients to see). Should it send a symlink as a regular file, or simply just omit it? If the answer is "the former", then we do not have to worry about it any further after applying your patch. Otherwise we still have to do something _else_ after applying your patch. I did not know which way we would want to proceed, and I still don't.