Re: [PATCH] bisect: test merge base if good rev is not an ancestor of bad rev
Junio C Hamano <gitster@pobox.com> writes:
> I have not looked at your implementation, but I do not think:
Sheesh. "I *do* think"...
Show 7 quoted lines
> - The current one is not "fully reliable"; the user needs to know what
> he is doing. You might call it "prone to user errors".
>
> - "Test this merge-base before going forward, please" will add typically
> only one round of check (if you have more merge bases between good and
> bad, you need to test all of them are good to be sure), so it is not
> "slower nor more complex".
and I think it is a reasonable thing to do.
Junio C Hamano <gitster@pobox.com>