Re: [PATCH] builtin-config: add --exec-editor for use in scripts

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 2, 2009, 03:04 UTC
Message-ID: <7v4ozdo7yt.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090201025349.GA22160@dcvr.yhbt.net>

Eric Wong <normalperson@yhbt.net> writes:

Show 14 quoted lines

> This exposes the launch_editor() library function for use by
> various scripting languages.  This allows the ensure consistent
> handling of GIT_EDITOR/VISUAL/EDITOR environment variables as
> well as the handling of special characters such as spaces in the
> various environment variables.
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>
>  I'm not sure if git-config is the best place to stick it.  I plan to
>  start using this in git-svn but I don't want to implement Git::Editor
>  in Perl and have to keep track of editor.c.  Of course this also makes
>  the logic/rules used in libgit usable to any other scripting language
>  capable of launching other programs.

I agree that git-config is probably a wrong place. A separate command "git editor" (or "git user-preference --editor", if you extend it to pager and others) perhaps?

I also agree that something like this would make scripting Porcelains a much pleasant experience.