git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: allow disabling expensive broken symlink checks

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 3, 2009, 06:52 UTC
Message-ID
<7v4ozcdnbt.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20090203044549.GA2483@dcvr.yhbt.net>
Eric Wong <normalperson@yhbt.net> writes:
Show 22 quoted lines
>> How common is this breakage in people's subversion repositories that
>> dbc6c74d (git-svn: handle empty files marked as symlinks in SVN,
>> 2009-01-11) works around?
>
> It's not common at all.  Some broken Windows clients were able to
> create it.
>
>> What's the way to recover from a broken import, when the subversion
>> repository does have such a breakage, and the user used git-svn that
>> predates dbc6c74?  Is it very involved, and it is much better to have the
>> safety by default than to force everybody else who interacts with
>> non-broken subversion repository suffer from this performance penalty?
>
> Previously, git-svn would just stop importing and refuse to continue.
> So allowing the user to enable it would be a problem; too.  I don't
> recall the error being easy to distinguish from other errors.
>
>> Because the fix (that is broken from the performance angle) is relatively
>> recent, I am wondering if it makes more sense to turn it off by default,
>> and allow people with such a broken history to optionally turn it on.
>
> I'm considering disabling it by default, too.

I leave it entirely up to you to choose whichever default you find sensible (I do not think I have to say this). I wasn't complaining your original choice to stay on the safer side, with an option to trigger a faster but potentially riskier behaviour.

I was curious how black-and-white the deciding factor for a sensible default would be for this particular case.

Previous: Eric WongNext: Eric Wong
Message 8 of 11 in “"git svn fetch" slow”
  1. Markus HeidelbergJan 31, 2009
  2. Sverre RabbelierJan 31, 2009
  3. Markus HeidelbergJan 31, 2009
  4. Sverre RabbelierJan 31, 2009
  5. git-svn: allow disabling expensive broken symlink checksEric Wong, Feb 1, 2009
  6. Junio C HamanoFeb 2, 2009
  7. Eric WongFeb 3, 2009
  8. Junio C HamanoFeb 3, 2009
  9. Eric WongFeb 3, 2009
  10. Eric WongFeb 5, 2009
  11. Junio C HamanoFeb 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.