Re: [PATCH 2/2] bisect: string commands emited by "filter_skipped" together with "&&"

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2009, 07:01 UTC
Message-ID: <7v4oygnz29.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090227073146.6699964f.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 9 quoted lines

> diff --git a/git-bisect.sh b/git-bisect.sh
> index a9324b2..08e31d6 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -296,14 +296,14 @@ filter_skipped() {
>  	do
> ...
>  	done
> +	echo ':'

Is there a particular reason you moved this echo ':' out of the downstream of the pipe as I wrote in my response?

It logically belongs to the downstream in this pattern:

        producer of the list of items | {
                preparatory steps
                while read one item
                do
                        process one item
                        echo "something &&"
                done
                echo ":" ;# to conclude the && chain
        }

But you changed it to:

        preparatory step that does not concern producer

        producer of the list of items |
                while read one item
                do
                        process one item
                        echo "something &&"
                done

        echo ":"

which looks to me a lot less logical code structure.