Re: [PATCH] allow OFS_DELTA objects during a push
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 1, 2009, 23:49 UTC
- Message-ID
- <7v4ow4v0xl.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.LFD.2.00.0905011616130.6741@xanadu.home>
Thanks.
The code looks correct, I am reasonably sure updated server-client combination would work fine, and use of the capability mechanism means other combinations like old pusher and new receiver, and/or new pusher and old receiver, should be also Ok.
I see Shawn did the same to jgit.
But I'd like to queue this in 'next', and make it official after 1.6.3 happens.
I just do not want to repeat silly mistakes, this close to the final, similar to the "github needs to get stuck forever at 1.6.1" we made with 40c155f (push: prepare sender to receive extended ref information from the receiver, 2008-09-09); it was done as a good change after a discussion among Shawn, Daniel and I. We managed to botch it and had to later fix with 02322e1 (send-pack: do not send unknown object name from ".have" to pack-objects, 2009-01-27).
(references)
http://thread.gmane.org/gmane.comp.version-control.git/95351 http://thread.gmane.org/gmane.comp.version-control.git/95072 http://thread.gmane.org/gmane.comp.version-control.git/107417/focus=107500