Re: [PATCH 1/6] GITWEB - Load Checking
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 11, 2009, 01:10 UTC
- Message-ID
- <7v4ony8ge7.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <m34onye3h8.fsf@localhost.localdomain>
Jakub Narebski <jnareb@gmail.com> writes:
Show 9 quoted lines
>> +# loadavg throttle
>> +sub get_loadavg() {
>> + my $load;
>> + my @loads;
>> +
>> + open($load, '<', '/proc/loadavg') or return 0;
>
> Why not use one of existing CPAN modules: Sys::Info::Device::CPU,
> BSD::getloadavg, Sys::CpuLoad?I would prefer to hear something along the lines of...
I like this. Here is a follow-up patch you can squash in to
support other platforms.I gave the patches a cursory look (I somehow didn't see 5/6, though) and they all looked decently done, except that some of the lines were excessively long.