Re: [PATCH] diff: handle lines containing only whitespace better

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 20, 2010, 16:08 UTC
Message-ID: <7v4ocgx2we.fsf@alter.siamese.dyndns.org>
In-Reply-To: <780B144B-03E0-4ED5-8E92-D4EB3CBBBF71@sb.org>

Kevin Ballard <kevin@sb.org> writes:

> Incidentally, I just realized the description of the patch is slightly
> wrong. The problem only occurs when the line contains at least one
> tab...

That exactly is why I asked for tests, as I couldn't reproduce it from the description at all.

But I see it now.

	$ HT='   '
	$ mv Makefile Makefile+
        $ sed -e "3s/^.*/$HT/" Makefile+ >Makefile
        $ git diff --color

> ...Should I resend the patch with an updated description? I can also
> attempt to write tests if you can give me some guidance on how to deal
> with the need for ansi color codes.

This may show us a good starting point.

    $ git grep RED t/