Re: [PATCH] string_list_append: always set util pointer to NULL

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 12, 2011, 07:43 UTC
Message-ID: <7v4o89zoi1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110212051850.GA715@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> It is not immediately obvious that the util field may
> contain random bytes after appending an item. Especially
> since the string_list_insert* functions _do_ explicitly zero
> the util pointer.
>
> This does not appear to be a bug in any current git code, as
> all callers either fill in the util field immediately or
> never use it. However, it is worth it to be less surprising
> to new users of the string-list API who may expect it to be
> intialized to NULL.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> This bit me in some new code I was writing. I consider it a bug fix, but ...

Of course; the "Especially since" part is very convincing.