Re: [PATCH v4 2/2] push: Don't push a repository with unpushed submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 18, 2011, 20:32 UTC
Message-ID: <7v4o1ea2at.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110818192157.GA10598@book.hvoigt.net>

Heiko Voigt <hvoigt@hvoigt.net> writes:

Show 10 quoted lines

> On Sun, Aug 14, 2011 at 11:03:33AM +0200, Fredrik Gustafsson wrote:
>> When working with submodules it is easy to forget to push a
>> submodule to the server but pushing a super-project that
>> contains a commit for that submodule. The result is that the
>> superproject points at a submodule commit that is not available
>> on the server.
>
> Since I do not see thisi in pu maybe you missed this? There was a series
> containing the same patch send before which Jens asked to ignore but
> this was the one which was meant to be included.

Hmm, this is how the messages look like in my threaded MUA:

  [  34: Fredrik Gustafsson     ] [PATCH v4 0/2] push limitations
   [ 377: Fredrik Gustafsson     ] [PATCH v4 2/2] push: Don't push a reposi...
   [  35: Jens Lehmann           ] Re: [PATCH v4 0/2] push limitations
  [ 377: Fredrik Gustafsson     ] [PATCH v4 2/2] push: Don't push a reposit...
   [  14: Heiko Voigt            ]

where Jens says "Please ignore this series, it slipped by accident" in the third one. And the second [PATCH v4 2/2] message that you are reminding me of (thanks!) has the identical proposed commit log message and patch text as the other [PATCH v4 2/2] message.

So I am not sure what is going on here.

Also I vaguely recall that I said something about the command line parser for this new option during the review of the previous round. Has that been resolved/corrected?