Re: [PATCH v2] contrib: added git-diffall

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 23, 2012, 17:37 UTC
Message-ID: <7v4nuh5u3b.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F460D45.7000804@gmail.com>

Stefano Lattarini <stefano.lattarini@gmail.com> writes:

Show 15 quoted lines

>>> +# mktemp is not available on all platforms (missing from msysgit)
>>> +# Use a hard-coded tmp dir if it is not available
>>> +tmp="$(mktemp -d -t tmp.XXXXXX 2>/dev/null)" || {
>>> +	tmp=/tmp/git-diffall-tmp
>>> +}
>>  ...
>   # mktemp is not available on all platforms (missing from msysgit)
>    tmp=$(mktemp -d -t tmp.XXXXXX 2>/dev/null) || {
>        tmp=/tmp/git-diffall-tmp.$$
>        mkdir "$tmp" || fatal "couldn't create temporary directory"
>   }
>
>>> +mkdir -p "$tmp"
>>
> At which point this should be removed, of course.

Good eyes; thanks.