git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation: improve description of GIT_EDITOR and preference order

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 26, 2012, 18:31 UTC
Message-ID
<7v4ntbp61t.fsf@alter.siamese.dyndns.org>
In-Reply-To
<loom.20120326T100258-967@post.gmane.org>
Rodrigo Silva "(MestreLion)"  <linux@rodrigosilva.com> writes:
> So, what should I do now? Re-send the patch with just the accepted parts
> (and adjusting commit message accordingly)? Or this will be done by you?

People either say "Yeah, I agree with the suggestions---can you apply it without the change to git-var.txt?", or respond to the review message with an updated patch with "I agree with the review suggestion and dropped the change to git-var.txt" after the three-dash lines (i.e. the comment does not become part of the commit log message).

For something small and easy like this one, it's OK to do either way.

For larger changes, people tend to do the latter, as often they do not agree (and they do not have to) with *all* the point raised in the review, and it would become more error prone to let me pick, choose and edit the original submission.

I'll just apply your patch with minor tweaks.  Thanks.
Previous: Rodrigo Silva (MestreLion)
Message 4 of 4 in “Documentation: improve description of GIT_EDITOR and preference order”
  1. Documentation: improve description of GIT_EDITOR and preference orderRodrigo Silva (MestreLion), Mar 23, 2012
  2. Junio C HamanoMar 23, 2012
  3. Rodrigo Silva (MestreLion)Mar 26, 2012
  4. Junio C HamanoMar 26, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.