Re: How can I specify the "sendmail" program for git-send-email?

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 11, 2012, 15:57 UTC
Message-ID: <7v4nqh96z5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CABPQNSZ1dyAfCVLGcLxbeBdS_9A_arYOhzgKBtndReK5zxu_MA@mail.gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

> Well, I've always been slightly annoyed by the "send-mail" vs
> "sendemail" inconsistency.

Hrm, isn't it between "sendmail" (as in /usr/lib/sendmail) and "send-email" (a subcommand of git)?

> Perhaps we could do something along these
> lines (plus all documentation-updates, omitted for clarity) to reduce
> the risk of confusion?

Assuming that the contrast between "sendmail" and "git send-email" is what you are trying to address, I fail to see how it would help reducing the confusion if you start naming configuration variables used by "git send-email" without E.

If the proposal were to give "send-email.$var" synomyms to corresponding "sendemail.$var" variables, I would have been persuaded to believe it may alleviate potential confusion, though.

Show 22 quoted lines

> Yeah, the leaking of $identity between different sections is a bit
> suboptimal, but as a fallback-mechanism I don't think it actually
> matters much.
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 03292fd..d167d96 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -375,7 +375,11 @@ sub read_config {
>  	}
>  }
>
> -# read configuration from [sendemail "$identity"], fall back on [sendemail]
> +# read configuration from [sendmail "$identity"], fall back on [sendmail]
> +$identity = Git::config(@repo, "sendmail.identity") unless (defined $identity);
> +read_config("sendmail.$identity") if (defined $identity);
> +read_config("sendmail");
> +# same as above, but with legacy "sendemail"
>  $identity = Git::config(@repo, "sendemail.identity") unless (defined
> $identity);
>  read_config("sendemail.$identity") if (defined $identity);
>  read_config("sendemail");