Re: [PATCH 1/2] notes get-ref: --expand expands the output notes ref.

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 6, 2012, 05:23 UTC
Message-ID: <7v4nnb67x1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALKQrgem2KM07vA0LeVgD6HkM1yMDBSfThKUZ7aBaxpbcC49hA@mail.gmail.com>

Johan Herland <johan@herland.net> writes:

Show 8 quoted lines

> On Wed, Sep 5, 2012 at 2:52 PM, W. Trevor King <wking@tremily.us> wrote:
>> From: "W. Trevor King" <wking@tremily.us>
>>
>> Useful for debugging refs that don't seem to be expanding correctly.
>>
>> Signed-off-by: W. Trevor King <wking@tremily.us>
>
> Acked-by: Johan Herland <johan@herland.net>

Really?  Would "git log --expand master" be useful?

I'd have to say that a DWIM that the user needs to diagnose with such a "feature" is a total failure. Can't we fix that root cause instead?

That is, for a name, e.g. "refs/remotes/origin/notes/commit" (the original example in [PATCH 0/2]) or "commit" (the usual):

 - If it is already a ref, just use that (e.g. use that stuff in the
   refs/remotes/ hierarchy); or

 - If it is not, prefix refs/notes/ to it.

or something?